feat: Remove e2ee config from edit room panel#36945
Merged
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: acb2643 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
WalkthroughRemoved end-to-end encryption (E2EE) UI and permission checks from the Edit Room panel and its permissions hook, removed the related E2E test and page-object locator, and added a changeset documenting the removal. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant ERI as EditRoomInfo (UI)
participant PERM as useEditRoomPermissions
participant S as Permission Store
U->>ERI: Open Edit Room
ERI->>PERM: Request permissions
PERM->>S: Compute allowed settings (E2E excluded)
S-->>PERM: Flags (readOnly, archived, joinCode, hideSysMsgs, ...)
PERM-->>ERI: Permissions (no E2E flags)
note over ERI: Render edit form without encrypted field
U->>ERI: View/modify available settings
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–30 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36945 +/- ##
===========================================
+ Coverage 66.17% 67.09% +0.91%
===========================================
Files 3220 3404 +184
Lines 114930 117782 +2852
Branches 20806 21487 +681
===========================================
+ Hits 76056 79026 +2970
+ Misses 36413 36062 -351
- Partials 2461 2694 +233
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
yash-rajpal
approved these changes
Sep 17, 2025
This was referenced Sep 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Since we already have the option to toggle the e2ee through from the toolbox, the product team decided to remove the option from the edit room panel, avoiding duplicated actions with the same purpose.
Issue(s)
Steps to test or reproduce
Further comments
CORE-1353
Summary by CodeRabbit
Refactor
Tests
Chores