Skip to content

refactor: Decouple admin users table data from layout#36884

Merged
kodiakhq[bot] merged 2 commits into
developfrom
refactor/adminUsersTable
Sep 8, 2025
Merged

refactor: Decouple admin users table data from layout#36884
kodiakhq[bot] merged 2 commits into
developfrom
refactor/adminUsersTable

Conversation

@dougfabris

@dougfabris dougfabris commented Sep 8, 2025

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-1340

@dionisio-bot

dionisio-bot Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Sep 8, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5d1e8a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.11.0 milestone Sep 8, 2025
@codecov

codecov Bot commented Sep 8, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.20280% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.27%. Comparing base (46e37bf) to head (5d1e8a1).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36884      +/-   ##
===========================================
+ Coverage    66.24%   66.27%   +0.02%     
===========================================
  Files         3340     3341       +1     
  Lines       113572   113686     +114     
  Branches     21155    21169      +14     
===========================================
+ Hits         75235    75341     +106     
- Misses       35650    35657       +7     
- Partials      2687     2688       +1     
Flag Coverage Δ
e2e 57.68% <100.00%> (-0.02%) ⬇️
unit 70.99% <97.16%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review September 8, 2025 18:15
@dougfabris dougfabris requested a review from a team as a code owner September 8, 2025 18:15

@MartinSchoeler MartinSchoeler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Sep 8, 2025
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 8, 2025
@kodiakhq kodiakhq Bot merged commit 2b9cc5d into develop Sep 8, 2025
48 checks passed
@kodiakhq kodiakhq Bot deleted the refactor/adminUsersTable branch September 8, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants