fix: Restore iframe authentication behavior#36866
Merged
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 871590c The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #36866 +/- ##
===========================================
- Coverage 66.27% 66.25% -0.02%
===========================================
Files 3339 3339
Lines 113726 113729 +3
Branches 21177 21144 -33
===========================================
- Hits 75369 75353 -16
- Misses 35666 35687 +21
+ Partials 2691 2689 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
MartinSchoeler
approved these changes
Sep 8, 2025
Member
Author
|
/backport 7.10.3 |
Contributor
|
Pull request #37298 added to Project: "Patch 7.10.3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When the authentication iframe API call fails (for example, due to CORS issues), the application does not display the iframe login page. Instead, it falls back to the default login page. It should always fallback to iframe authentication login page.
Issue(s)
Steps to test or reproduce
Further comments
CORE-1334