Skip to content

fix: Restore iframe authentication behavior#36866

Merged
kodiakhq[bot] merged 5 commits into
developfrom
fix/iframe-auth-behavior
Sep 8, 2025
Merged

fix: Restore iframe authentication behavior#36866
kodiakhq[bot] merged 5 commits into
developfrom
fix/iframe-auth-behavior

Conversation

@yash-rajpal

@yash-rajpal yash-rajpal commented Sep 3, 2025

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

When the authentication iframe API call fails (for example, due to CORS issues), the application does not display the iframe login page. Instead, it falls back to the default login page. It should always fallback to iframe authentication login page.

Issue(s)

Steps to test or reproduce

  • Go to Administration → Accounts → Iframe
  • Enable iframe login
  • Configure iframe login with a valid Iframe URL and API URL
  • Start your server-side login page
  • Simulate a failing API call (e.g., by having CORS not sent on headers)
  • Open Rocket.Chat login page in an incognito window

Further comments

CORE-1334

@dionisio-bot

dionisio-bot Bot commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Sep 3, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 871590c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Sep 3, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.25%. Comparing base (2b9cc5d) to head (871590c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36866      +/-   ##
===========================================
- Coverage    66.27%   66.25%   -0.02%     
===========================================
  Files         3339     3339              
  Lines       113726   113729       +3     
  Branches     21177    21144      -33     
===========================================
- Hits         75369    75353      -16     
- Misses       35666    35687      +21     
+ Partials      2691     2689       -2     
Flag Coverage Δ
e2e 57.70% <0.00%> (-0.02%) ⬇️
unit 70.98% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yash-rajpal yash-rajpal marked this pull request as ready for review September 8, 2025 15:20
@yash-rajpal yash-rajpal requested a review from a team as a code owner September 8, 2025 15:20
@dougfabris dougfabris added this to the 7.11.0 milestone Sep 8, 2025
@yash-rajpal yash-rajpal added the stat: QA assured Means it has been tested and approved by a company insider label Sep 8, 2025
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 8, 2025
@dionisio-bot dionisio-bot Bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 8, 2025
@yash-rajpal yash-rajpal added the stat: ready to merge PR tested and approved waiting for merge label Sep 8, 2025
@kodiakhq kodiakhq Bot merged commit e7aacb2 into develop Sep 8, 2025
48 checks passed
@kodiakhq kodiakhq Bot deleted the fix/iframe-auth-behavior branch September 8, 2025 20:59
@yash-rajpal

Copy link
Copy Markdown
Member Author

/backport 7.10.3

@dionisio-bot

dionisio-bot Bot commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

Pull request #37298 added to Project: "Patch 7.10.3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants