fix: #36479 - Persistent Null found in Logs leading to undesired behaviour.#36508
Open
4rch50nist wants to merge 7 commits into
Open
fix: #36479 - Persistent Null found in Logs leading to undesired behaviour.#365084rch50nist wants to merge 7 commits into
4rch50nist wants to merge 7 commits into
Conversation
…ot diagnose why it was able to come that deep to begin with.
…at#36424) Co-authored-by: Diego Sampaio <8591547+sampaiodiego@users.noreply.github.com>
…ot diagnose why it was able to come that deep to begin with.
|
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36479 by putting in a guard for when
usersMapis null itself thereby error-ing out when access tousersMap.userNameTableis done for nullity.The steps to reproduce the error described in #36479 are not provided, hence I could not verify/test, however based on the logs provided (which were very helpful), it seems that this is indeed a result of a null in
usersMapitself.