Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@blewjy
Copy link
Contributor

@blewjy blewjy commented Mar 21, 2019

@RocketChat/ios

Closes #2530

No hints will be generated if it is detected that the word containing the "/" character is not the first word.

Screenshots after fix:
not-first-word first-word

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #2599 into develop will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2599      +/-   ##
===========================================
- Coverage    26.15%   25.99%   -0.16%     
===========================================
  Files          463      463              
  Lines        17203    17203              
===========================================
- Hits          4499     4472      -27     
- Misses       12704    12731      +27
Impacted Files Coverage Δ
.../Chat/MessagesViewControllerComposerDelegate.swift 0% <ø> (ø) ⬆️
...anagers/Model/AuthManager/AuthManagerRecover.swift 36.36% <0%> (-60.61%) ⬇️
Rocket.Chat/Extensions/Models/AuthExtensions.swift 66.66% <0%> (-33.34%) ⬇️
...Chat/Models/Subscription/SubscriptionQueries.swift 70% <0%> (-30%) ⬇️
Rocket.Chat/Managers/PushManager.swift 24.13% <0%> (-10.35%) ⬇️
Rocket.Chat/Managers/AppManager.swift 36.04% <0%> (-4.07%) ⬇️
...Chat/Controllers/Chat/MessagesViewController.swift 34.25% <0%> (+2.75%) ⬆️
...ontrollers/Base/Main/MainSplitViewController.swift 52.5% <0%> (+7.5%) ⬆️
...ocket.Chat/Extensions/Models/ObjectExtension.swift 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd19bf4...501c7d6. Read the comment docs.

@rafaelks rafaelks added this to the 3.4.0 milestone Mar 21, 2019
@rafaelks
Copy link
Contributor

Amazing, thank you!!! :)

@rafaelks rafaelks merged commit 43b49b6 into RocketChat:develop Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Auto suggesting slash commands even when not first character

2 participants