Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@cardoso
Copy link
Member

@cardoso cardoso commented Nov 24, 2018

@RocketChat/ios

  • Users need to be the last 5 to send messages in the current channel
  • Darkened background
  • Align avatars with 'Suggestions' & cell separator with usernames
  • remove own user from list

Closes #2347

@cardoso cardoso added this to the 3.2.0 milestone Nov 24, 2018
@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #2367 into develop will increase coverage by 0.05%.
The diff coverage is 39.13%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2367      +/-   ##
===========================================
+ Coverage     25.8%   25.85%   +0.05%     
===========================================
  Files          443      444       +1     
  Lines        16632    16696      +64     
===========================================
+ Hits          4292     4317      +25     
- Misses       12340    12379      +39
Impacted Files Coverage Δ
.../Chat/MessagesViewControllerComposerDelegate.swift 0% <ø> (ø) ⬆️
...ons/UIViewController/UIViewControllerDimming.swift 0% <0%> (ø)
...t/Controllers/Chat/MessagesComposerViewModel.swift 0% <0%> (ø) ⬆️
...Chat/Controllers/Chat/MessagesViewController.swift 42.23% <66.66%> (+0.29%) ⬆️
Rocket.Chat/Extensions/Models/UserExtensions.swift 69.69% <66.66%> (-2.72%) ⬇️
...cket.Chat/Controllers/Chat/MessagesViewModel.swift 35.22% <75%> (+7.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0691ef1...88d0c04. Read the comment docs.

@cardoso cardoso changed the title [WIP][IMPROVEMENT][RCVC] HintsView layout adjustments & user priority [IMPROVEMENT][RCVC] HintsView layout adjustments & user priority Dec 4, 2018
Copy link
Contributor

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 💯

@rafaelks rafaelks merged commit 148fd73 into develop Dec 5, 2018
@rafaelks rafaelks deleted the imp/dim_bg_autocomplete branch December 5, 2018 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants