This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[CHORE] Use dataSorted to calculate cell's size #2299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelks
suggested changes
Nov 9, 2018
| indexPath.section < dataNormalized.count, | ||
| indexPath.row < dataNormalized[indexPath.section].elements.count | ||
| indexPath.section < dataSorted.count, | ||
| indexPath.row < dataSorted[indexPath.section].viewModels().count |
Contributor
There was a problem hiding this comment.
Let's request viewModels() just once and save it to get the right reference later?
rafaelks
approved these changes
Nov 9, 2018
Codecov Report
@@ Coverage Diff @@
## develop #2299 +/- ##
===========================================
- Coverage 26.02% 26.01% -0.01%
===========================================
Files 433 433
Lines 15849 15850 +1
===========================================
Hits 4124 4124
- Misses 11725 11726 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios