[CHORE] Libraries updates: Realm, Nuke, Fabric, Crashlytics and more... #2292
Conversation
| public init(urlRequest: URLRequest, targetSize: CGSize, contentMode: ImageDecompressor.ContentMode) { | ||
| self = ImageRequest(urlRequest: urlRequest) | ||
| self.processor = AnyImageProcessor(ImageDecompressor(targetSize: targetSize, contentMode: contentMode)) | ||
| public init(urlRequest: URLRequest, targetSize: CGSize, contentMode: ImageDecompressor.ContentMode, upscale: Bool = false) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)
| } | ||
|
|
||
| internal func decompress(_ image: UIImage, targetSize: CGSize, contentMode: ImageDecompressor.ContentMode) -> UIImage { | ||
| internal func decompress(_ image: UIImage, targetSize: CGSize, contentMode: ImageDecompressor.ContentMode, upscale: Bool) -> UIImage { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 134 characters (line_length)
| /// - parameter `maxConcurrentRequestCount`: 2 by default. | ||
| public init(pipeline: ImagePipeline = ImagePipeline.shared, maxConcurrentRequestCount: Int = 2) { | ||
| /// - parameter destination: `.memoryCache` by default. | ||
| public init(pipeline: ImagePipeline = ImagePipeline.shared, destination: Destination = .memoryCache, maxConcurrentRequestCount: Int = 2) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 142 characters (line_length)
| } | ||
|
|
||
| private func _url(for key: Key) -> URL? { | ||
| /* testable */ func _url(for key: Key) -> URL? { |
There was a problem hiding this comment.
Identifier Name Violation: Function name should start with a lowercase character: '_url(for:)' (identifier_name)
Codecov Report
@@ Coverage Diff @@
## develop #2292 +/- ##
==========================================
+ Coverage 25.86% 25.96% +0.1%
==========================================
Files 432 432
Lines 15869 15857 -12
==========================================
+ Hits 4105 4118 +13
+ Misses 11764 11739 -25
Continue to review full report at Codecov.
|
@RocketChat/ios
Updates
3.10.7to3.11.1› CHANGELOG1.7.11to1.8.1› CHANGELOG5.3.0to5.12.0› CHANGELOG7.3.2to7.5.1› CHANGELOG5.0to6.0› CHANGELOG3.9.0to3.11.1› CHANGELOG4.1.0to4.2.0› CHANGELOG