-
Notifications
You must be signed in to change notification settings - Fork 437
[IMPROVEMENT] Minor improvements to theming on RCVC #2268
[IMPROVEMENT] Minor improvements to theming on RCVC #2268
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/integrate-rc-view-controller #2268 +/- ##
========================================================================
+ Coverage 25.61% 25.63% +0.01%
========================================================================
Files 437 437
Lines 16507 16517 +10
========================================================================
+ Hits 4229 4234 +5
- Misses 12278 12283 +5
Continue to review full report at Codecov.
|
| @@ -1,5 +1,5 @@ | |||
| // | |||
| // Themeable.swift | |||
| // Theme.swift | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! :-)
| @objc let tintColor: UIColor | ||
| @objc let auxiliaryTintColor: UIColor | ||
| @objc let brightBlue: UIColor | ||
| @objc let actionTintColor: UIColor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed a better name! 👍
rafaelks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you @Sameesunkaria 🇮🇹!
|
👍 Sent with GitHawk |
@RocketChat/ios