Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@Sameesunkaria
Copy link
Contributor

@RocketChat/ios

  • Add MessagesViewController as an observer for theming
  • Use colors without transparency to improve performance
  • Rename brightBlue to actionTintColor so that it matches the naming convention

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #2268 into feature/integrate-rc-view-controller will increase coverage by 0.01%.
The diff coverage is 18.75%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##           feature/integrate-rc-view-controller    #2268      +/-   ##
========================================================================
+ Coverage                                 25.61%   25.63%   +0.01%     
========================================================================
  Files                                       437      437              
  Lines                                     16507    16517      +10     
========================================================================
+ Hits                                       4229     4234       +5     
- Misses                                    12278    12283       +5
Impacted Files Coverage Δ
...Views/Subscriptions/SubscriptionsSortingView.swift 0% <ø> (ø) ⬆️
...ket.Chat/Views/Subscriptions/ServersListView.swift 0% <ø> (ø) ⬆️
...ews/Chat/New Chat/Cells/BaseAudioMessageCell.swift 0% <0%> (ø) ⬆️
...hat/Views/Chat/New Chat/Cells/MessageURLCell.swift 0% <0%> (ø) ⬆️
...Views/Chat/New Chat/Cells/MessageActionsCell.swift 0% <0%> (ø) ⬆️
...ket.Chat/Views/Chat/New Chat/Cells/QuoteCell.swift 0% <0%> (ø) ⬆️
Rocket.Chat/Managers/MarkdownManager.swift 8.51% <0%> (ø) ⬆️
Rocket.Chat/Theme/ThemeableViews.swift 52.38% <0%> (-0.16%) ⬇️
...t/Views/Chat/New Chat/Cells/QuoteMessageCell.swift 0% <0%> (ø) ⬆️
Rocket.Chat/Theme/Theme.swift 95.45% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab3bf4...90a7f82. Read the comment docs.

@@ -1,5 +1,5 @@
//
// Themeable.swift
// Theme.swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! :-)

@objc let tintColor: UIColor
@objc let auxiliaryTintColor: UIColor
@objc let brightBlue: UIColor
@objc let actionTintColor: UIColor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed a better name! 👍

Copy link
Contributor

@rafaelks rafaelks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @Sameesunkaria 🇮🇹!

@rafaelks rafaelks merged commit c65aa5a into RocketChat:feature/integrate-rc-view-controller Oct 30, 2018
@rafaelks rafaelks added this to the 3.2.0 milestone Oct 30, 2018
@filipealva
Copy link
Contributor

👍

Sent with GitHawk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants