This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[CHORE] Resolve couple code warnings in the project #2246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipealva
approved these changes
Oct 11, 2018
Contributor
filipealva
left a comment
There was a problem hiding this comment.
Great! 💯 just waiting the CI pass to merge
Codecov Report
@@ Coverage Diff @@
## feature/integrate-rc-view-controller #2246 +/- ##
=======================================================================
- Coverage 26.86% 26.77% -0.1%
=======================================================================
Files 418 418
Lines 15739 15700 -39
=======================================================================
- Hits 4229 4204 -25
+ Misses 11510 11496 -14
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Oct 11, 2018
|
|
||
| currentRealm?.execute({ (realm) in | ||
| guard let detachedSubscription = realm.object(ofType: Subscription.self, forPrimaryKey: subscriptionIdentifier ?? "") else { return } | ||
| guard let detachedSubscription = realm.object(ofType: Subscription.self, forPrimaryKey: subscriptionIdentifier) else { return } |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 143 characters (line_length)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios