Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Aug 3, 2018

@RocketChat/ios

@rafaelks rafaelks added this to the 3.1.0 milestone Aug 3, 2018
@rafaelks rafaelks requested a review from filipealva August 3, 2018 11:34
@rafaelks rafaelks changed the title [CHORE] Add events for "New Workspace" & "Status Changed" [CHORE] Add events for "New Workspace" & "Status Update" Aug 3, 2018
@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #2106 into develop will increase coverage by 0.42%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2106      +/-   ##
===========================================
+ Coverage    35.47%   35.89%   +0.42%     
===========================================
  Files          382      382              
  Lines        17916    17922       +6     
===========================================
+ Hits          6355     6433      +78     
+ Misses       11561    11489      -72
Impacted Files Coverage Δ
...references/Profile/StatusTableViewController.swift 0% <0%> (ø) ⬆️
....Chat/Controllers/Auth/WelcomeViewController.swift 81.08% <0%> (-2.26%) ⬇️
Rocket.Chat/Managers/AnalyticsManager.swift 59.03% <100%> (+1.01%) ⬆️
...Chat/Models/Subscription/SubscriptionQueries.swift 75% <0%> (-25%) ⬇️
...at/Controllers/Base/BaseNavigationController.swift 42.5% <0%> (-12.5%) ⬇️
...at/Controllers/Auth/AuthNavigationController.swift 32.2% <0%> (-10.17%) ⬇️
Rocket.Chat/Managers/PushManager.swift 57.37% <0%> (-4.92%) ⬇️
...ket.Chat/Controllers/Base/BaseViewController.swift 80.48% <0%> (-4.88%) ⬇️
Rocket.Chat/API/APIRequest.swift 94.59% <0%> (-2.71%) ⬇️
Rocket.Chat/Managers/AppManager.swift 62.61% <0%> (-0.47%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c02e79...abc0d0d. Read the comment docs.

return
}

AnalyticsManager.log(event: .newWorkspace)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to rename this event to showNewWorkspace or something like that, to make it clear that the user just viewed the "new workspace" screen. In the future, we can add parameters to the go.rocket.chat deeplinks to identify when the user just created a workspace and is coming back to the app. That way we will be able to generate a pipeline where this showNewWorkspace is when the user enters and the event triggered by the deeplink is the conversion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, just updated it! 👍

Copy link
Contributor

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@filipealva filipealva merged commit cada780 into develop Aug 3, 2018
@filipealva filipealva deleted the chore/add_few_more_tracking_events branch August 3, 2018 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants