fix(e2e): restore testID='sidebar-view' on SidebarView#7259
Conversation
Commit e718561 removed the SafeAreaView wrapper that carried testID='sidebar-view'. Maestro flows that wait for id: sidebar-view after tapping rooms-list-view-sidebar were timing out, breaking 5 of 13 Android E2E shards. Re-attach the testID to the existing ScrollView. No layout change.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used📓 Path-based instructions (4)**/*.{js,ts,jsx,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
app/views/**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧠 Learnings (1)📚 Learning: 2026-04-22T22:57:58.545ZApplied to files:
🔇 Additional comments (1)
WalkthroughA Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
testID='sidebar-view'to<ScrollView>inapp/views/SidebarView/index.tsx. Re-enables Maestro drawer flows that were timing out.Root cause
Commit
e7185612e "Add voice call item on sidebar"removed the<SafeAreaView testID='sidebar-view'>wrapper without re-attaching the testID. 5 of 13 Android E2E shards were failing every drawer-opening flow withAssertion is false: id: sidebar-view is visible.Reference failing run: https://github.com/RocketChat/Rocket.Chat.ReactNative/actions/runs/25008420199/job/73243273302
Test plan
maestro test .maestro/tests/assorted/change-avatar.yamlpasses thesidebar-viewvisibility step.Summary by CodeRabbit