Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@hfeky
Copy link
Contributor

@hfeky hfeky commented May 3, 2019

@RocketChat/android

Changes:

  1. Added all missing Arabic translations.
  2. Corrected some translations in Arabic and Persian.
  3. Changed "others" to "other" in msg_search_for_global_users_description string resource for all files.
  4. Added missing strings in some resource files like title_choose_language, status, user_detail_status, msg_video_call, msg_join_video_call, message_video_call_started, msg_credentials_saved_successfully.
  5. Removed non-translatable strings that were added in some resource files other than the default one like msg_more_than_ninety_nine_unread_messages, foss.
  6. Made status and user_detail_status strings be translatable.
  7. Added missing space/enclosing tags in some xml comments.
  8. Removed unused file dialog_report.xml.

@hfeky hfeky changed the title [I18N] Translated Arabic strings [I18N] Translated Arabic strings, added missing strings May 3, 2019
Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the improvements and translations done here! Thanks!

@philipbrito philipbrito merged commit 6682a19 into RocketChat:develop May 4, 2019
@philipbrito philipbrito added this to the 3.4.0 milestone May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants