This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Sort chats by unread on top. #2263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented sorting option unread on top to work with different combinations of sorting options.
Contributor
|
@nbamir There is a conflict. Can you resolve it? |
Contributor
Author
|
Thank you for pointing it out. I'll look into it! |
philipbrito
suggested changes
Apr 26, 2019
app/src/main/java/chat/rocket/android/chatrooms/ui/ChatRoomsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatrooms/ui/ChatRoomsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatrooms/ui/ChatRoomsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatrooms/infrastructure/ChatRoomsRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatrooms/viewmodel/ChatRoomsViewModel.kt
Outdated
Show resolved
Hide resolved
Fixed code formatting.
Updated variable names.
Fixed formatting.
Fixed variable names.
philipbrito
suggested changes
Apr 28, 2019
Contributor
philipbrito
left a comment
There was a problem hiding this comment.
@nbamir Could you please fix the errors here?
app/src/main/java/chat/rocket/android/chatrooms/viewmodel/ChatRoomsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatrooms/viewmodel/ChatRoomsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatrooms/viewmodel/ChatRoomsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/chat/rocket/android/chatrooms/viewmodel/ChatRoomsViewModel.kt
Outdated
Show resolved
Hide resolved
philipbrito
approved these changes
Apr 29, 2019
Contributor
philipbrito
left a comment
There was a problem hiding this comment.
Thank you very much for sending it @nbamir!
💯
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/android
Closes #2254
Closes #1660
Closes #1976
Changes:
Implemented sorting option unread on top to work with sort by name, by activity and by group type.
Gif Showing Implementation