This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[FIX] Typo in VersionCheckView.kt #2219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected sentence.
Contributor
|
@nbamir I think sending separate PRs for typo fix in each file is not good when you can do all of the fixes in one PR. Hope you understand. |
Contributor
Author
|
Hi, I don't have previous experience with open source contribution so I'm trying to get the hang of it. Any suggestions or advice is welcome. I didn't know I could commit fixes in different files in one PR. Thanks for the heads up. |
Contributor
|
@nbamir This will help https://stackoverflow.com/questions/19576116/how-to-add-multiple-files-to-git-at-the-same-time. You can also look at official documentation of git to learn more about it here |
Contributor
Author
|
Thank you for the suggestion. I'll check it out. |
philipbrito
reviewed
Apr 15, 2019
Contributor
philipbrito
left a comment
There was a problem hiding this comment.
Thanks for sending this PR @nbamir
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/android
Changes:
Corrected sentence.
Screenshots or GIF for the change: