Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@hfeky
Copy link
Contributor

@hfeky hfeky commented Apr 9, 2019

@RocketChat/android

Changes:

This pull request brings some fixes to typos, sentence structure and translation mistakes.

  1. Changed Github to GitHub
  2. Changed Gitlab to GitLab
  3. Changed Linkedin to LinkedIn
  4. Changed Wordpress to WordPress
  5. Replaced the string resource name msg_forgot__your_password with msg_forgot_your_password
  6. Replaced the string resource name msg__your_2fa_code with msg_your_2fa_code
  7. Replaced the string resource name msg_profile_update_successfully with msg_profile_updated_successfully
  8. Added a missing question mark in msg_delete_description string resource in some translations
  9. Fixed some Arabic translation mistakes
  10. Fixed question mark direction in some strings in Arabic and Persian strings resource files
  11. Translated 4 strings in Spanish strings resource file
  12. Changed statics to statistics and improving to improve in preferences messages section in the default strings resource file
  13. Fixed the string resource max_file_size_exceeded not taking the expected two arguments in Arabic strings resource file

hfeky added 3 commits April 9, 2019 16:46
1. Changed statics to statistics
2. Changed improving to improve
@philipbrito
Copy link
Contributor

@HusseinElFeky Could you fix the conflicts here?

@hfeky
Copy link
Contributor Author

hfeky commented Apr 16, 2019

@filipedelimabrito I have merged the branches. Please check if any further change is required.

@philipbrito philipbrito added this to the 3.4.0 milestone Apr 18, 2019
@hfeky
Copy link
Contributor Author

hfeky commented Apr 18, 2019

@filipedelimabrito I removed the wildcard import. Thanks for pointing it out.

Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for making it @HusseinElFeky 💯

@philipbrito philipbrito merged commit a3a92f6 into RocketChat:develop Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants