This repository was archived by the owner on Jun 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 552
[FIX] Typos and Translation Mistakes #2214
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Changed statics to statistics 2. Changed improving to improve
Contributor
|
@HusseinElFeky Could you fix the conflicts here? |
Contributor
Author
|
@filipedelimabrito I have merged the branches. Please check if any further change is required. |
philipbrito
suggested changes
Apr 18, 2019
app/src/main/java/chat/rocket/android/profile/ui/ProfileFragment.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@filipedelimabrito I removed the wildcard import. Thanks for pointing it out. |
philipbrito
approved these changes
Apr 18, 2019
Contributor
philipbrito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for making it @HusseinElFeky 💯
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/android
Changes:
This pull request brings some fixes to typos, sentence structure and translation mistakes.
msg_forgot__your_passwordwithmsg_forgot_your_passwordmsg__your_2fa_codewithmsg_your_2fa_codemsg_profile_update_successfullywithmsg_profile_updated_successfullymsg_delete_descriptionstring resource in some translationsmax_file_size_exceedednot taking the expected two arguments in Arabic strings resource file