Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@dev-ritik
Copy link
Contributor

@RocketChat/android

Closes #1995

Changes: Uses method onBackPressed() to exit the app only from ChatRoomsFragment.

@philipbrito philipbrito changed the title Fix #1995: app close on back button press [IMPROVEMENT] Avoid closing the app from some screens. Jan 15, 2019
Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed some formatting issues here.

Thank you very much for sending this PR @dev-ritik!
P.s: Thanks for "closing the drawer" as well! 💯

@philipbrito philipbrito added this to the 3.3.0 milestone Jan 15, 2019
@philipbrito philipbrito merged commit 31c879b into RocketChat:develop Jan 15, 2019
@dev-ritik dev-ritik deleted the issue_1995 branch January 15, 2019 20:45
@dev-ritik
Copy link
Contributor Author

Thanks, @filipedelimabrito for pointing that out.
I shall keep that in mind from the next time.

@philipbrito
Copy link
Contributor

Don't worry @dev-ritik . You can just follow the coding style pointed here :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants