Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@divyanshub024
Copy link
Contributor

@RocketChat/android

Closes #1990

Changes:

Use androidx.appcompat.app.AlertDialog class rather than android.app.AlertDialog.

Screenshots:

Copy link
Contributor

@philipbrito philipbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed some wrong formatting here 👍
Thank you very much for this PR @divyanshub024 💯

Copy link
Contributor

@GOVINDDIXIT GOVINDDIXIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 👍

@divyanshub024
Copy link
Contributor Author

divyanshub024 commented Jan 14, 2019

@filipedelimabrito What's the code style you guys are using? For me, tab size: 4, indent: 4 and continuation indent: 8

@philipbrito
Copy link
Contributor

@divyanshub024 This one: https://github.com/RocketChat/Rocket.Chat.Android#coding-style

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Alert button not showing title.

3 participants