[FIX] roomid or username required bug

[dabbler011]

@RocketChat/android

Closes #1912

chatRoom object was instantiated with empty id. So, toDirectMessage() was called with empty id in clickListeners.

Works fine now.

[rafaelks]

Thanks for the PR, but this problem fixes the alert, but you can't chat with the person because there's no "Send" button or the emoji button doesn't work.

[dabbler011]

The problem was because the newly created room was not added in the database due to which listeners were not instantiated. I suppose refreshing chat rooms in db before accessing them fixes the issue. I have commited changes for the same.

@rafaelks please review.

[rafaelks]

@dabbler011 "Send button" still don't show up on new conversations.

[dabbler011]

@rafaelks are you sure? As it is working just fine for me.

[rafaelks]

Just tested the latest build here, check it out:

[leonardoaramaki]

@dabbler011 change the following method on ChatRoomPresenter to this and we should be good to merge:

private suspend fun subscribeRoomChanges() {
    withContext(CommonPool + strategy.jobs) {
            chatRoomId?.let {
                manager.addRoomChannel(it, roomChangesChannel)
                for (room in roomChangesChannel) {
                    dbManager.getRoom(room.id)?.let {
                        view.onRoomUpdated(roomMapper.map(chatRoom = it, showLastMessage = true))
                    }
                }
            }
        }
}

[leonardoaramaki]

Changes pointed out comments.

[dabbler011]

@leonardoaramaki updated the method.

[leonardoaramaki]

Thanks @dabbler011. Testing