Skip to content

bulk: add hooks, remove simulation controller config, add rbfiqus and rbwatcher - #75

Merged
rafa-martin merged 16 commits into
jazzy-develfrom
feat/jazzy/gz-webhook
Sep 11, 2025
Merged

bulk: add hooks, remove simulation controller config, add rbfiqus and rbwatcher#75
rafa-martin merged 16 commits into
jazzy-develfrom
feat/jazzy/gz-webhook

Conversation

@rafa-martin

@rafa-martin rafa-martin commented Aug 25, 2025

Copy link
Copy Markdown
Member

This pull request updates the documentation and repository structure to improve clarity, maintainability, and consistency, especially around robot model definitions and formatting standards. The key changes include a major rewrite and clarification of the robot creation guide, the introduction of code formatting requirements using Prettier, and updates to the list and structure of supported robots.

Documentation improvements and robot definition guide:

  • The CreateURDF.md file has been extensively rewritten for clarity and updated to reflect current best practices for defining new robots, including modernized xacro usage, simplified argument and property handling, and improved example code. The guide now better explains macro usage and robot structure.

Repository structure and supported robots:

  • New supported robots: RB-WATCHER and RB-FIQUS
  • The README.md has been updated to accurately list all available robots and their corresponding folders, correcting and expanding the robot list to include new models such as rb1, rbficus, rbsummit_steel, and rbwatcher. The folder structure section now matches these updates. [1] [2]

Code formatting and contribution guidelines:

  • Contribution guidelines have been added to the README.md, requiring all XML, Xacro, and URDF files to be formatted using Prettier with a specific configuration. Instructions for installing Prettier and formatting files are provided.
  • A new Prettier configuration file .github/.prettierrc.json has been added, specifying formatting rules for XML and related files to ensure consistency across the codebase.This pull request updates documentation and introduces formatting guidelines for the project. The main changes include a significant rewrite and reorganization of the CreateURDF.md guide to clarify the process of defining new robots, updates to the README.md to better list available robots and provide contribution guidelines, and the addition of a Prettier configuration for consistent formatting of XML and Xacro files.

Documentation improvements:

  • Major rewrite and restructuring of CreateURDF.md to clarify and modernize the process for defining new robots, including updated examples, argument usage, macro structure, and improved explanations.
  • Expanded and reorganized the list of available robots in README.md for improved clarity and accuracy. [1] [2]

Contribution and formatting guidelines:

  • Added a "Contributing" section to README.md with instructions for installing and running Prettier (with XML plugin) to format URDF, XML, and Xacro files.
  • Introduced a Prettier configuration file .github/.prettierrc.json to enforce consistent formatting across XML-related files.

This comment was marked as outdated.

@marbosjo
marbosjo requested a review from Copilot August 28, 2025 11:31

This comment was marked as outdated.

@rafa-martin rafa-martin changed the title chore: add gazebo hooks [WIP] chore: add gazebo hooks Aug 29, 2025
@rafa-martin
rafa-martin marked this pull request as draft August 29, 2025 07:38
@rafa-martin
rafa-martin marked this pull request as ready for review September 3, 2025 06:37
@rafa-martin
rafa-martin marked this pull request as draft September 3, 2025 06:37
@rafa-martin rafa-martin changed the title [WIP] chore: add gazebo hooks bulk: add hooks, remove simulation controller config, add rbfiqus and rbwatcher Sep 3, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request performs extensive code formatting and cleanup across URDF/xacro files for multiple robot descriptions. The main purpose is to improve code consistency, readability, and maintainability across the robotnik_description package.

Key changes:

  • Consistent XML formatting with proper indentation and line breaks
  • Updated references from M_PI and PI to ${pi} throughout all files
  • Standardized xacro macro declarations with multi-line parameter formatting
  • Added new robot configurations for rbficus, rbwatcher, and related steering wheel components

Reviewed Changes

Copilot reviewed 93 out of 106 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
urdf/wheels/*.xacro Reformatted wheel definitions with consistent spacing and updated PI references
urdf/bodies//.xacro Standardized robot body descriptions with improved formatting
urdf/structures/ewellix/*.xacro Added ros2_control configurations to lift mechanisms
urdf/bases//.xacro Updated robot base definitions with gazebo_ignition support
simulators/gazebo_ignition//.yaml Added controller parameter configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread urdf/wheels/rubber_wheel/rubber_wheel.urdf.xacro
Comment thread urdf/wheels/mecanum_wheel/rbrobout_mecanum_wheel.urdf.xacro
Comment thread urdf/wheels/mecanum_wheel/rbrobout_mecanum_wheel.urdf.xacro
Comment thread urdf/wheels/mecanum_wheel/rbkairos_mecanum_wheel.urdf.xacro
Comment thread urdf/wheels/mecanum_wheel/rbkairos_mecanum_wheel.urdf.xacro
Comment thread urdf/structures/ewellix/ewellix_lift_900mm.urdf.xacro
Comment thread urdf/wheels/caster_wheel/rbtheron_caster.urdf.xacro Outdated
rafa-martin and others added 2 commits September 9, 2025 12:19
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rafa-martin
rafa-martin marked this pull request as ready for review September 11, 2025 06:29
@RomanRobotnik

Copy link
Copy Markdown
Contributor

It requires RobotnikAutomation/robotnik_sensors#59

@RomanRobotnik RomanRobotnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@RomanRobotnik

Copy link
Copy Markdown
Contributor

Please try to add the most important info when squashing and merging

@rafa-martin
rafa-martin merged commit b14797f into jazzy-devel Sep 11, 2025
@rafa-martin
rafa-martin deleted the feat/jazzy/gz-webhook branch September 11, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants