bulk: add hooks, remove simulation controller config, add rbfiqus and rbwatcher - #75
Merged
Conversation
rafa-martin
marked this pull request as draft
August 29, 2025 07:38
rafa-martin
marked this pull request as ready for review
September 3, 2025 06:37
rafa-martin
marked this pull request as draft
September 3, 2025 06:37
There was a problem hiding this comment.
Pull Request Overview
This pull request performs extensive code formatting and cleanup across URDF/xacro files for multiple robot descriptions. The main purpose is to improve code consistency, readability, and maintainability across the robotnik_description package.
Key changes:
- Consistent XML formatting with proper indentation and line breaks
- Updated references from
M_PIandPIto${pi}throughout all files - Standardized xacro macro declarations with multi-line parameter formatting
- Added new robot configurations for rbficus, rbwatcher, and related steering wheel components
Reviewed Changes
Copilot reviewed 93 out of 106 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| urdf/wheels/*.xacro | Reformatted wheel definitions with consistent spacing and updated PI references |
| urdf/bodies//.xacro | Standardized robot body descriptions with improved formatting |
| urdf/structures/ewellix/*.xacro | Added ros2_control configurations to lift mechanisms |
| urdf/bases//.xacro | Updated robot base definitions with gazebo_ignition support |
| simulators/gazebo_ignition//.yaml | Added controller parameter configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rafa-martin
marked this pull request as ready for review
September 11, 2025 06:29
Contributor
|
It requires RobotnikAutomation/robotnik_sensors#59 |
Contributor
|
Please try to add the most important info when squashing and merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation and repository structure to improve clarity, maintainability, and consistency, especially around robot model definitions and formatting standards. The key changes include a major rewrite and clarification of the robot creation guide, the introduction of code formatting requirements using Prettier, and updates to the list and structure of supported robots.
Documentation improvements and robot definition guide:
CreateURDF.mdfile has been extensively rewritten for clarity and updated to reflect current best practices for defining new robots, including modernized xacro usage, simplified argument and property handling, and improved example code. The guide now better explains macro usage and robot structure.Repository structure and supported robots:
README.mdhas been updated to accurately list all available robots and their corresponding folders, correcting and expanding the robot list to include new models such asrb1,rbficus,rbsummit_steel, andrbwatcher. The folder structure section now matches these updates. [1] [2]Code formatting and contribution guidelines:
README.md, requiring all XML, Xacro, and URDF files to be formatted using Prettier with a specific configuration. Instructions for installing Prettier and formatting files are provided..github/.prettierrc.jsonhas been added, specifying formatting rules for XML and related files to ensure consistency across the codebase.This pull request updates documentation and introduces formatting guidelines for the project. The main changes include a significant rewrite and reorganization of theCreateURDF.mdguide to clarify the process of defining new robots, updates to theREADME.mdto better list available robots and provide contribution guidelines, and the addition of a Prettier configuration for consistent formatting of XML and Xacro files.Documentation improvements:
CreateURDF.mdto clarify and modernize the process for defining new robots, including updated examples, argument usage, macro structure, and improved explanations.README.mdfor improved clarity and accuracy. [1] [2]Contribution and formatting guidelines:
README.mdwith instructions for installing and running Prettier (with XML plugin) to format URDF, XML, and Xacro files..github/.prettierrc.jsonto enforce consistent formatting across XML-related files.