Revert "Remove deregistered objects from the inactive overload cache" - #35
Merged
Merged
Conversation
2 tasks
EricCousineau-TRI
approved these changes
Jan 14, 2020
Collaborator
There was a problem hiding this comment.
Thanks for catching this!
The only CI failures are on macOS Python 3, but it's due to what seems like a Homebrew flake. Ignoring for now.
EDIT: Hoisted re-explanation to top-level.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #32
This change cause segfaults on Mac CI: RobotLocomotion/drake#12105
EDIT(eric): This was PR'd against this pybind11 fork and merged, then incoprorated into a Drake PR as a commit update.
The Drake PR was then reverted in #12105, but the commit was not reverted in pybind11 itself, hence this PR.
This change is