fix(quality): move inner helper functions to module scope (S7721)#479
Merged
fix(quality): move inner helper functions to module scope (S7721)#479
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
e7ddeed to
a04dfd1
Compare
Move pure helper functions that do not close over any outer-scope variables from inside describe blocks to module scope, preventing them from being recreated on every test invocation. Files changed: - tests/unit/confluence.test.ts: mockFetchResponse - tests/unit/slack.test.ts: setupChannelList, setupMessages, setupUserInfo, setupThreadReplies - tests/unit/onenote.test.ts: setupGraphMocks - tests/unit/code-chunker.test.ts: MockNode interface, makeMockNode, createMockedChunker - tests/unit/obsidian.test.ts: setupVaultFs (deduplicated — both copies merged into one module-scope function) - tests/unit/config.test.ts: makeConfig Closes #473 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
a04dfd1 to
6dcfe9f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
describeblocks to module scopeconfluence.test.ts,slack.test.ts,onenote.test.ts,code-chunker.test.ts,obsidian.test.ts(deduplicates two identical copies ofsetupVaultFs),config.test.tsCloses #473
Test plan
npm run typecheckpasses🤖 Generated with Claude Code