fix(quality): reduce cognitive complexity of spiderUrl generator (S3776)#476
Merged
fix(quality): reduce cognitive complexity of spiderUrl generator (S3776)#476
Conversation
Flatten the nested `if (depth > 0) { if (skipped) continue; }` block
into a single guarded continue, and remove the redundant inner
maxPages check (already guarded by the while condition and the
post-loop abortReason assignment). Brings cognitive complexity from
19 down to 14, resolving SonarCloud CRITICAL S3776.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if (depth > 0) { if (skipped) continue; }into a single guardedcontinuemaxPagescheck (already guarded by the while-loop condition)spiderUrlfrom 21 → 14 (threshold: 15)Resolves SonarCloud CRITICAL issue typescript:S3776 in
src/core/spider.ts.Closes #473
Test plan
npm run typecheckpassesnpm testpasses🤖 Generated with Claude Code