fix: miscellaneous minor SonarCloud issues (S7755, S4325, S3863, S7748, S7778)

src/cli/index.ts

@@ -69,15 +69,16 @@ import {
   syncOneNote,
   disconnectOneNote,
 } from "../connectors/onenote.js";
-import { loadConnectorConfig, saveConnectorConfig } from "../connectors/index.js";
-import { syncNotion, disconnectNotion } from "../connectors/notion.js";
-import type { NotionConfig } from "../connectors/notion.js";
-import { syncSlack, disconnectSlack, type SlackConfig } from "../connectors/slack.js";
 import {
+  loadConnectorConfig,
+  saveConnectorConfig,
   saveNamedConnectorConfig,
   loadNamedConnectorConfig,
   hasNamedConnectorConfig,
 } from "../connectors/index.js";
+import { syncNotion, disconnectNotion } from "../connectors/notion.js";
+import type { NotionConfig } from "../connectors/notion.js";
+import { syncSlack, disconnectSlack, type SlackConfig } from "../connectors/slack.js";
 import {
   createSavedSearch,
   listSavedSearches,

src/core/dedup.ts

@@ -77,7 +77,7 @@ export async function checkDuplicate(
 
     if (row) {
       log.debug({ existingDocId: row.id }, "Exact duplicate detected via content hash");
-      return { isDuplicate: true, matchType: "exact", existingDocId: row.id, similarity: 1.0 };
+      return { isDuplicate: true, matchType: "exact", existingDocId: row.id, similarity: 1 };
     }
   }
 

src/core/indexing.ts

@@ -59,7 +59,7 @@ function startChunkAtHeading(
   line: string,
 ): { lines: string[]; length: number } {
   const level = (headingMatch[1] ?? "").length;
-  while (headingStack.length > 0 && (headingStack[headingStack.length - 1]?.level ?? 0) >= level) {
+  while (headingStack.length > 0 && (headingStack.at(-1)?.level ?? 0) >= level) {
     headingStack.pop();
   }
   const breadcrumb = headingStack.map((h) => h.text).join(" > ");

src/core/parsers/csv.ts

@@ -22,8 +22,10 @@ export class CsvParser implements DocumentParser {
         cell.replace(/\\/g, "\\\\").replace(/\|/g, "\\|").replace(/\n/g, " ");
 
       const lines: string[] = [];
-      lines.push("| " + header.map(escapeCell).join(" | ") + " |");
-      lines.push("| " + header.map(() => "---").join(" | ") + " |");
+      lines.push(
+        "| " + header.map(escapeCell).join(" | ") + " |",
+        "| " + header.map(() => "---").join(" | ") + " |",
+      );
       for (const row of rows) {
         // Normalize row length to match header
         const normalized = Array.from({ length: colCount }, (_, i) => row[i] ?? "");

src/core/search.ts

@@ -718,8 +718,7 @@ function keywordSearch(
   const baseParams = [...params];
 
   sql += " LIMIT ? OFFSET ?";
-  params.push(limit);
-  params.push(offset);
+  params.push(limit, offset);
 
   const KeywordRowSchema = z.object({
     chunk_id: z.string(),
@@ -1086,8 +1085,7 @@ function fts5Search(
   let baseParams = [...params];
 
   sql += " ORDER BY rank LIMIT ? OFFSET ?";
-  params.push(limit);
-  params.push(offset);
+  params.push(limit, offset);
 
   const Fts5RowSchema = z.object({
     chunk_id: z.string(),
@@ -1140,8 +1138,7 @@ function fts5Search(
     baseParams = [...orParams];
 
     orSql += " ORDER BY rank LIMIT ? OFFSET ?";
-    orParams.push(limit);
-    orParams.push(offset);
+    orParams.push(limit, offset);
 
     rows = validateRows(Fts5RowSchema, db.prepare(orSql).all(...orParams), "fts5Search.orRows");
   }

src/core/tags.ts

@@ -462,7 +462,7 @@ export function suggestTags(
   for (const [term, count] of tf) {
     if (existingTags.has(term)) continue;
     const normalizedTf = count / maxTf;
-    const knownBoost = knownTags.has(term) ? 2.0 : 1.0;
+    const knownBoost = knownTags.has(term) ? 2 : 1;
     scored.push({ term, score: normalizedTf * knownBoost });
   }
 

tests/unit/batch-search.test.ts

@@ -2,8 +2,7 @@ import { describe, it, expect, beforeEach, afterEach } from "vitest";
 import type Database from "better-sqlite3";
 import { createTestDbWithVec } from "../fixtures/test-db.js";
 import { MockEmbeddingProvider } from "../fixtures/mock-provider.js";
-import { seedTestDocument } from "../fixtures/helpers.js";
-import { insertChunk } from "../fixtures/helpers.js";
+import { seedTestDocument, insertChunk } from "../fixtures/helpers.js";
 import {
   searchBatch,
   BATCH_SEARCH_MAX_REQUESTS,

tests/unit/dedup.test.ts

@@ -43,7 +43,7 @@ describe("dedup", () => {
 
       expect(result.isDuplicate).toBe(true);
       expect(result.matchType).toBe("exact");
-      expect(result.similarity).toBe(1.0);
+      expect(result.similarity).toBe(1);
       expect(result.existingDocId).toBeDefined();
     });
 

tests/unit/obsidian.test.ts

@@ -1,5 +1,9 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
-import { parseObsidianMarkdown } from "../../src/connectors/obsidian.js";
+import {
+  parseObsidianMarkdown,
+  syncObsidianVault,
+  disconnectVault,
+} from "../../src/connectors/obsidian.js";
 import { createTestDb, createTestDbWithVec } from "../fixtures/test-db.js";
 import { MockEmbeddingProvider } from "../fixtures/mock-provider.js";
 import type Database from "better-sqlite3";
@@ -29,7 +33,6 @@ vi.mock("node:fs/promises", async (importOriginal) => {
 });
 
 import { readdirSync, readFileSync, statSync, existsSync, writeFileSync } from "node:fs";
-import { syncObsidianVault, disconnectVault } from "../../src/connectors/obsidian.js";
 import { initLogger } from "../../src/logger.js";
 
 const mockedReaddirSync = vi.mocked(readdirSync);