fix: use String#replaceAll() over replace() with global flag (S7781)

src/cli/index.ts

@@ -69,15 +69,16 @@ import {
   syncOneNote,
   disconnectOneNote,
 } from "../connectors/onenote.js";
-import { loadConnectorConfig, saveConnectorConfig } from "../connectors/index.js";
-import { syncNotion, disconnectNotion } from "../connectors/notion.js";
-import type { NotionConfig } from "../connectors/notion.js";
-import { syncSlack, disconnectSlack, type SlackConfig } from "../connectors/slack.js";
 import {
+  loadConnectorConfig,
+  saveConnectorConfig,
   saveNamedConnectorConfig,
   loadNamedConnectorConfig,
   hasNamedConnectorConfig,
 } from "../connectors/index.js";
+import { syncNotion, disconnectNotion } from "../connectors/notion.js";
+import type { NotionConfig } from "../connectors/notion.js";
+import { syncSlack, disconnectSlack, type SlackConfig } from "../connectors/slack.js";
 import {
   createSavedSearch,
   listSavedSearches,

src/connectors/obsidian.ts

@@ -156,7 +156,7 @@ function transformObsidianBody(body: string, fileMap: Map<string, string>): stri
     /(?<!!)\[\[([^\]|]+)(?:\|([^\]]*))?\]\]/g,
     (_match, link: string, display?: string) => {
       const displayText = display ?? link;
-      const slug = link.toLowerCase().replace(/\s+/g, "-");
+      const slug = link.toLowerCase().replaceAll(/\s+/g, "-");
       return `[${displayText}](${slug})`;
     },
   );

src/connectors/onenote.ts

@@ -223,10 +223,10 @@ export function convertOneNoteHtml(html: string): string {
   let md = nhm.translate(processed).trim();
 
   // Post-process: replace tokens with final markdown
-  md = md.replace(/CHECKDONE7X9Z\s*/g, "- [x] ");
-  md = md.replace(/CHECKTODO7X9Z\s*/g, "- [ ] ");
-  md = md.replace(/INKPLACEHOLDER7X9Z/g, "[handwritten content]");
-  md = md.replace(/IMGPLACEHOLDER7X9Z/g, "[image]");
+  md = md.replaceAll(/CHECKDONE7X9Z\s*/g, "- [x] ");
+  md = md.replaceAll(/CHECKTODO7X9Z\s*/g, "- [ ] ");
+  md = md.replaceAll("INKPLACEHOLDER7X9Z", "[handwritten content]");
+  md = md.replaceAll("IMGPLACEHOLDER7X9Z", "[image]");
   md = md.replace(/FILEATTACH7X9Z([^\s]+?)ENDATTACH7X9Z/g, "[attached: $1]");
 
   return md;

src/connectors/slack.ts

@@ -289,7 +289,7 @@ function formatTimestamp(ts: string): string {
 }
 
 function truncateTitle(text: string, maxLen: number = 80): string {
-  const cleaned = text.replace(/\n/g, " ").trim();
+  const cleaned = text.replaceAll("\n", " ").trim();
   if (cleaned.length <= maxLen) return cleaned;
   return cleaned.slice(0, maxLen - 3) + "...";
 }

src/core/dedup.ts

@@ -77,7 +77,7 @@ export async function checkDuplicate(
 
     if (row) {
       log.debug({ existingDocId: row.id }, "Exact duplicate detected via content hash");
-      return { isDuplicate: true, matchType: "exact", existingDocId: row.id, similarity: 1.0 };
+      return { isDuplicate: true, matchType: "exact", existingDocId: row.id, similarity: 1 };
     }
   }
 

src/core/indexing.ts

@@ -59,7 +59,7 @@ function startChunkAtHeading(
   line: string,
 ): { lines: string[]; length: number } {
   const level = (headingMatch[1] ?? "").length;
-  while (headingStack.length > 0 && (headingStack[headingStack.length - 1]?.level ?? 0) >= level) {
+  while (headingStack.length > 0 && (headingStack.at(-1)?.level ?? 0) >= level) {
     headingStack.pop();
   }
   const breadcrumb = headingStack.map((h) => h.text).join(" > ");
@@ -223,7 +223,7 @@ function addDeduplicatedChunks(
   seenHashes: Set<string>,
 ): void {
   for (const chunk of windowChunks) {
-    const normalized = chunk.replace(/\s+/g, " ").trim();
+    const normalized = chunk.replaceAll(/\s+/g, " ").trim();
     const hash = createHash("sha256").update(normalized).digest("hex");
     if (!seenHashes.has(hash)) {
       seenHashes.add(hash);

src/core/packs.ts

@@ -693,9 +693,9 @@ function matchesExcludePattern(relativePath: string, pattern: string): boolean {
   // Escape regex special chars except * and **
   const escaped = pattern
     .replace(/[.+^${}()|[\]\\]/g, "\\$&")
-    .replace(/\*\*/g, "\0")
-    .replace(/\*/g, "[^/]*")
-    .replace(/\0/g, ".*");
+    .replaceAll("**", "\0")
+    .replaceAll("*", "[^/]*")
+    .replaceAll("\0", ".*");
   return new RegExp(`^${escaped}$`).test(relativePath);
 }
 

src/core/parsers/csv.ts

@@ -19,11 +19,13 @@ export class CsvParser implements DocumentParser {
       const rows = records.slice(1);
 
       const escapeCell = (cell: string): string =>
-        cell.replace(/\\/g, "\\\\").replace(/\|/g, "\\|").replace(/\n/g, " ");
+        cell.replaceAll("\\", "\\\\").replaceAll("|", "\\|").replaceAll("\n", " ");
 
       const lines: string[] = [];
-      lines.push("| " + header.map(escapeCell).join(" | ") + " |");
-      lines.push("| " + header.map(() => "---").join(" | ") + " |");
+      lines.push(
+        "| " + header.map(escapeCell).join(" | ") + " |",
+        "| " + header.map(() => "---").join(" | ") + " |",
+      );
       for (const row of rows) {
         // Normalize row length to match header
         const normalized = Array.from({ length: colCount }, (_, i) => row[i] ?? "");

src/core/parsers/epub.ts

@@ -38,8 +38,8 @@ export class EpubParser implements DocumentParser {
           const html: string = await getChapter.call(epub, item.id);
           // Strip HTML tags to get plain text
           const text = html
-            .replace(/<[^>]+>/g, " ")
-            .replace(/\s+/g, " ")
+            .replaceAll(/<[^>]+>/g, " ")
+            .replaceAll(/\s+/g, " ")
             .trim();
           if (text.length > 0) {
             chapters.push(text);

src/core/parsers/html.ts

@@ -14,7 +14,7 @@ export class HtmlParser implements DocumentParser {
       const markdown = nhm.translate(html);
 
       // Collapse excessive blank lines left by ignored elements
-      return Promise.resolve(markdown.replace(/\n{3,}/g, "\n\n").trimEnd());
+      return Promise.resolve(markdown.replaceAll(/\n{3,}/g, "\n\n").trimEnd());
     } catch (err: unknown) {
       const message = err instanceof Error ? err.message : "Unknown HTML parsing error";
       throw new ValidationError(`Failed to parse HTML: ${message}`);

src/core/search.ts

@@ -182,7 +182,7 @@ function computeRrfScores(map: Map<string, RankedItem>): SearchResult[] {
   for (const item of map.values()) {
     let rrfScore = 0;
     for (const rank of item.ranks) {
-      rrfScore += 1.0 / (RRF_K + rank);
+      rrfScore += 1 / (RRF_K + rank);
     }
     const boostFactors = [...item.result.scoreExplanation.boostFactors];
     fused.push({
@@ -718,8 +718,7 @@ function keywordSearch(
   const baseParams = [...params];
 
   sql += " LIMIT ? OFFSET ?";
-  params.push(limit);
-  params.push(offset);
+  params.push(limit, offset);
 
   const KeywordRowSchema = z.object({
     chunk_id: z.string(),
@@ -825,7 +824,7 @@ export function getRelatedChunks(
 ): RelatedChunksResult {
   const { chunkId } = options;
   const limit = Math.max(1, Math.min(options.limit ?? 10, 1000));
-  const minScore = options.minScore ?? 0.0;
+  const minScore = options.minScore ?? 0;
 
   // Look up the source chunk
   const SourceChunkSchema = z.object({
@@ -1050,7 +1049,7 @@ function fts5Search(
 
   const needsRatingJoin = options.minRating !== undefined;
 
-  const ftsQuery = words.map((w) => `"${w.replace(/"/g, '""')}"`).join(" AND ");
+  const ftsQuery = words.map((w) => `"${w.replaceAll('"', '""')}"`).join(" AND ");
   const params: unknown[] = [ftsQuery];
 
   let sql = `
@@ -1086,8 +1085,7 @@ function fts5Search(
   let baseParams = [...params];
 
   sql += " ORDER BY rank LIMIT ? OFFSET ?";
-  params.push(limit);
-  params.push(offset);
+  params.push(limit, offset);
 
   const Fts5RowSchema = z.object({
     chunk_id: z.string(),
@@ -1140,8 +1138,7 @@ function fts5Search(
     baseParams = [...orParams];
 
     orSql += " ORDER BY rank LIMIT ? OFFSET ?";
-    orParams.push(limit);
-    orParams.push(offset);
+    orParams.push(limit, offset);
 
     rows = validateRows(Fts5RowSchema, db.prepare(orSql).all(...orParams), "fts5Search.orRows");
   }

src/core/spider.ts

@@ -277,7 +277,7 @@ function extractTitle(html: string, url: string): string {
     const parsed = new URL(url);
     const path = parsed.pathname.replace(/\/$/, "");
     const last = path.split("/").pop();
-    if (last) return last.replace(/[-_]/g, " ").replace(/\.\w+$/, "");
+    if (last) return last.replaceAll(/[-_]/g, " ").replace(/\.\w+$/, "");
     return parsed.hostname;
   } catch {
     return url;

src/core/tags.ts

@@ -462,7 +462,7 @@ export function suggestTags(
   for (const [term, count] of tf) {
     if (existingTags.has(term)) continue;
     const normalizedTf = count / maxTf;
-    const knownBoost = knownTags.has(term) ? 2.0 : 1.0;
+    const knownBoost = knownTags.has(term) ? 2 : 1;
     scored.push({ term, score: normalizedTf * knownBoost });
   }
 

src/core/topics.ts

@@ -32,7 +32,7 @@ export function createTopic(db: Database.Database, input: CreateTopicInput): Top
     input.name
       .toLowerCase()
       .replace(/[^a-z0-9]+/g, "-")
-      .replace(/^-|-$/g, "") || randomUUID();
+      .replaceAll(/^-|-$/g, "") || randomUUID();
 
   // Verify parent exists if provided
   if (input.parentId) {

src/core/webhooks.ts

@@ -163,7 +163,7 @@ function validateUrl(url: string): void {
 /** Resolve hostname and block private/internal IPs (SSRF protection). */
 export async function validateWebhookUrlSsrf(url: string): Promise<void> {
   const parsed = new URL(url);
-  const hostname = parsed.hostname.replace(/^\[|\]$/g, "");
+  const hostname = parsed.hostname.replaceAll(/^\[|\]$/g, "");
 
   const results = await Promise.allSettled([dns.resolve4(hostname), dns.resolve6(hostname)]);
   const addresses: string[] = [];

src/web/dashboard.ts

@@ -278,7 +278,7 @@ export function getDashboardHtml(): string {
 
   function escAttr(s) {
     if (!s) return '';
-    return s.replace(/&/g, '&amp;').replace(/"/g, '&quot;').replace(/'/g, '&#39;').replace(/</g, '&lt;').replace(/>/g, '&gt;');
+    return s.replaceAll('&', '&amp;').replaceAll('"', '&quot;').replaceAll("'", '&#39;').replaceAll('<', '&lt;').replaceAll('>', '&gt;');
   }
 
   // Event delegation for cards and delete buttons

tests/integration/retrieval-quality.test.ts

@@ -58,7 +58,7 @@ class TfIdfEmbeddingProvider implements EmbeddingProvider {
   private tokenize(text: string): string[] {
     return text
       .toLowerCase()
-      .replace(/[^a-z0-9]+/g, " ")
+      .replaceAll(/[^a-z0-9]+/g, " ")
       .split(/\s+/)
       .filter((w) => w.length > 1);
   }

tests/unit/batch-search.test.ts

@@ -2,8 +2,7 @@ import { describe, it, expect, beforeEach, afterEach } from "vitest";
 import type Database from "better-sqlite3";
 import { createTestDbWithVec } from "../fixtures/test-db.js";
 import { MockEmbeddingProvider } from "../fixtures/mock-provider.js";
-import { seedTestDocument } from "../fixtures/helpers.js";
-import { insertChunk } from "../fixtures/helpers.js";
+import { seedTestDocument, insertChunk } from "../fixtures/helpers.js";
 import {
   searchBatch,
   BATCH_SEARCH_MAX_REQUESTS,

tests/unit/dedup.test.ts

@@ -43,7 +43,7 @@ describe("dedup", () => {
 
       expect(result.isDuplicate).toBe(true);
       expect(result.matchType).toBe("exact");
-      expect(result.similarity).toBe(1.0);
+      expect(result.similarity).toBe(1);
       expect(result.existingDocId).toBeDefined();
     });
 

tests/unit/indexing.test.ts

@@ -189,15 +189,15 @@ More content here.`;
     // Build content where the same logical text appears with different whitespace
     const line = "Hello world this is a test line.";
     const variant1 = line + "\n";
-    const variant2 = line.replace(/ /g, "  ") + "\n"; // double spaces
+    const variant2 = line.replaceAll(" ", "  ") + "\n"; // double spaces
     // Interleave so overlap might pick up both
     const content = (variant1.repeat(50) + variant2.repeat(50)).repeat(2);
     const chunks = chunkContentStreaming(content, { windowSize: 512 });
 
     // After whitespace normalization, duplicates should be removed
     const seen = new Set<string>();
     for (const chunk of chunks) {
-      const normalized = chunk.replace(/\s+/g, " ").trim();
+      const normalized = chunk.replaceAll(/\s+/g, " ").trim();
       expect(seen.has(normalized)).toBe(false);
       seen.add(normalized);
     }

tests/unit/obsidian.test.ts

@@ -1,5 +1,9 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
-import { parseObsidianMarkdown } from "../../src/connectors/obsidian.js";
+import {
+  parseObsidianMarkdown,
+  syncObsidianVault,
+  disconnectVault,
+} from "../../src/connectors/obsidian.js";
 import { createTestDb, createTestDbWithVec } from "../fixtures/test-db.js";
 import { MockEmbeddingProvider } from "../fixtures/mock-provider.js";
 import type Database from "better-sqlite3";
@@ -29,7 +33,6 @@ vi.mock("node:fs/promises", async (importOriginal) => {
 });
 
 import { readdirSync, readFileSync, statSync, existsSync, writeFileSync } from "node:fs";
-import { syncObsidianVault, disconnectVault } from "../../src/connectors/obsidian.js";
 import { initLogger } from "../../src/logger.js";
 
 const mockedReaddirSync = vi.mocked(readdirSync);