Skip to content

RD-T39 Icon and Android build fixes#86

Merged
ucswift merged 1 commit intomasterfrom
develop
Feb 4, 2026
Merged

RD-T39 Icon and Android build fixes#86
ucswift merged 1 commit intomasterfrom
develop

Conversation

@ucswift
Copy link
Copy Markdown
Member

@ucswift ucswift commented Feb 4, 2026

Summary by CodeRabbit

  • Chores
    • Updated application's startup configuration and module resolution settings for improved bundling and routing behavior.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The changes update the Metro bundler configuration to exclude the electron directory and establish web-specific module resolution with custom mocking, while simultaneously changing the application's main entry point from Electron main process to Expo Router entry point.

Changes

Cohort / File(s) Summary
Metro Bundler Configuration
metro.config.js
Added electron directory exclusion via blockList, implemented custom resolveRequest override for web-specific mocks with fallback resolution, and extended unstable_conditionNames with browser, require, and react-native conditions.
Application Entry Point
package.json
Updated main entry point from "electron/main.js" to "expo-router/entry", redirecting application initialization from Electron main process to Expo Router.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • RD-T39 Fixing build #76: Related to the Metro web-mock setup—this PR adds a resolveRequest override using web-specific mocks in metro.config.js, while the retrieved PR ensures __mocks__ directory is included in Docker context for those mocks to function correctly.

Poem

🐰 Hops with glee through Metro's halls,
Web mocks whisper, Electron falls,
Expo Router takes the stage,
A bouncy new web-bundled page!
Browser conditions bloom so bright, 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions 'Icon and Android build fixes' but the changeset contains Metro bundler configuration updates (blockList, resolveRequest) and a main entry point change from Electron to Expo Router, which are unrelated to icon or Android build configurations. Update the title to accurately reflect the actual changes, such as 'Configure Metro bundler for web and update app entry point' or similar, depending on the actual intent of these modifications.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift
Copy link
Copy Markdown
Member Author

ucswift commented Feb 4, 2026

Approve

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit febf309 into master Feb 4, 2026
12 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant