Audio Player NC17 compatibility: EmptyFeaturePolicy

[Rello]

@rullzer can you help me on your change you applied here?
Add Feature-Policy header #16613
nextcloud/server#16613

This part of Audio Player breaks with NC17 beta 1
https://github.com/Rello/audioplayer/blob/master/lib/Http/ImageResponse.php

Error:
"Exception":"TypeError","Message":"Return value of OCP\\AppFramework\\Http\\Response::getFeaturePolicy() must be an instance of OCP\\AppFramework\\Http\\EmptyFeaturePolicy, null returned"

can you help me on what to do here?

thank you for your support

[rullzer]

You should call the default constructor. But let me add some hardning int he server so this doesn't break so hard.

[rullzer]

Should be fixed with nextcloud/server#16788

[Rello]

Thank you @rullzer
How do I need to „call the default constructor“?
How do I need to do it?

[rullzer]

See my PR.
But with beta2 it will be no longer needed

[Rello]

ok, that simple. I am continuing NC17 testing

thank you!

[Rello]

@rullzer your fix is not NC16 compatible.
so i need to remove it and wait for NC17.b2.

do you know when it is planned or if there is a way to get it working for both NCs?
thank you

[rullzer]

Beta 2 will be released tomorrow :)

[Rello]

sounds like a plan