Skip to content

Remove Bad Filter Logic #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjchristensen merged 1 commit into from
Feb 17, 2014
Merged

Remove Bad Filter Logic #887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions rxjava-core/src/main/java/rx/operators/OperatorFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,6 @@ public void onNext(T value) {
try {
if (predicate.call(value)) {
child.onNext(value);
} else {
/*
* Special casing of GroupedObservable since GroupedObservable ***MUST*** be subscribed to
* otherwise it will block the GroupBy operator.
*
* See https://github.com/Netflix/RxJava/issues/844
*/
if (value instanceof GroupedObservable) {
System.out.println("value is GroupedObservable");
@SuppressWarnings("rawtypes")
GroupedObservable go = (GroupedObservable) value;
System.out.println("********* unsubscribe from go");
go.take(0).subscribe();
}
}
} catch (Throwable ex) {
child.onError(ex);
Expand Down