Zip with iterable, removed old aggregator version and updated tests#741
Merged
benjchristensen merged 1 commit intoReactiveX:masterfrom Jan 14, 2014
Merged
Conversation
|
RxJava-pull-requests #656 SUCCESS |
Member
|
These are instance methods, none of our |
Member
Author
|
I went according to #653 where there was 2 zip overloads without strike-through. |
Member
|
Agreed on the overloads, but they should be static, correct? |
Member
Author
|
No. The intention was to chain them to an existing observable: Observable.from(1, 2, 3).zip(Arrays.asList(4, 5, 6), (a, b) -> a * b); |
Member
|
Makes sense, wasn't sure as it was different than all the other zip methods. Thanks for confirming. |
benjchristensen
added a commit
that referenced
this pull request
Jan 14, 2014
Zip with iterable, removed old aggregator version and updated tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listed in #653.