Delay with subscription and item delaying observables.#734
Merged
benjchristensen merged 2 commits intoReactiveX:masterfrom Jan 14, 2014
Merged
Delay with subscription and item delaying observables.#734benjchristensen merged 2 commits intoReactiveX:masterfrom
benjchristensen merged 2 commits intoReactiveX:masterfrom
Conversation
|
RxJava-pull-requests #648 SUCCESS |
Member
There was a problem hiding this comment.
Do the following codes do the same thing?
public <U> Observable<T> delay(
final Func1<? super T, ? extends Observable<U>> itemDelay) {
return flatMap(new Func1<T, Observable<T>>() {
@Override
public Observable<T> call(final T t1) {
return itemDelay.call(t1).take(1).map(new Func1<U, T>() {
@Override
public T call(U ignored) {
return t1;
}
});
}
});
}
Member
Author
There was a problem hiding this comment.
I checked Rx.NET and both onNext and onCompleted of the itemDelay's Observable trigger the value emission so this and mine is incorrect.
|
RxJava-pull-requests #660 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Jan 14, 2014
Delay with subscription and item delaying observables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listed in #653
Note: onError and onCompleted events of the source are immediately propagated and will prevent emitting any pending values.