Buffer with Observable boundary.#733
Merged
benjchristensen merged 1 commit intoReactiveX:masterfrom Jan 14, 2014
Merged
Conversation
|
RxJava-pull-requests #647 SUCCESS |
Member
There was a problem hiding this comment.
observer.onNext, onCompleted, onError can be called from different Observables, so I suppose we need to wrap it by a SynchronizedObserver.
Member
Author
There was a problem hiding this comment.
Observer is mostly used from the boundary observable but we can move the onXXX functions into the guard block.
Member
There was a problem hiding this comment.
According to Rx contract, I think all operators should support the following observer.
Observer<Integer> o = new Observer<Integer>() {
private int count = 0;
@Override
public void onCompleted() {
count++;
}
@Override
public void onError(Throwable e) {
count++;
}
@Override
public void onNext(Integer args) {
count++;
}
};
benjchristensen
added a commit
that referenced
this pull request
Jan 14, 2014
Buffer with Observable boundary.
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mentined in Issue #653.