Closed
Conversation
|
RxJava-pull-requests #522 SUCCESS |
Contributor
|
Oops. Some duplicate work of #576 |
Member
Author
|
Sorry, I've noticed it after the PR. At least 50% of mine is new; more if you count the test file :) |
Member
|
@samuelgruetter and @akarnokd Can the two of you please review each others code in #576 and #585 and determine what the merge of the two should look like and peer review to recommend what I should merge and when it's ready? |
Member
Author
|
Let's do the usual thing: merge @samuelgruetter 's work into main and I'll redo my part on the remaining Timer overload. |
Contributor
|
thank you :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement: #92
I've omitted the absolute time variants because of the earlier comments on Generate.
Related issue: #530