2.x: Fix Observable.concatMapEager queueing of source items#5609
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Sep 18, 2017
Merged
2.x: Fix Observable.concatMapEager queueing of source items#5609akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
JakeWharton
approved these changes
Sep 18, 2017
Codecov Report
@@ Coverage Diff @@
## 2.x #5609 +/- ##
============================================
+ Coverage 96.18% 96.25% +0.07%
+ Complexity 5837 5836 -1
============================================
Files 632 632
Lines 41473 41473
Branches 5745 5745
============================================
+ Hits 39889 39920 +31
+ Misses 632 611 -21
+ Partials 952 942 -10
Continue to review full report at Codecov.
|
artem-zinnatullin
approved these changes
Sep 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the wrong queue type in
Observable.concatMapEagerto be theSpscLinkedArrayQueueinstead of theSpscArrayQueue(the latter basically ignored items from the main source when it got full - a remnant from its boundedFlowablecousin). Unit tests added that ensure bothFlowableandObservablevariants work properly.Reported in: #5608