2.x: fix Obs.combineLatestDelayError sync initial error not emitting#5560
Merged
akarnokd merged 2 commits intoReactiveX:2.xfrom Aug 22, 2017
Merged
2.x: fix Obs.combineLatestDelayError sync initial error not emitting#5560akarnokd merged 2 commits intoReactiveX:2.xfrom
akarnokd merged 2 commits intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5560 +/- ##
============================================
- Coverage 96.32% 96.15% -0.17%
+ Complexity 5830 5820 -10
============================================
Files 631 631
Lines 41414 41417 +3
Branches 5740 5739 -1
============================================
- Hits 39890 39823 -67
- Misses 596 635 +39
- Partials 928 959 +31
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Aug 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the case reported in #5558 where a synchronous first, non-empty source triggered an error completion immediately instead of giving a chance to the other sources to form combinations.
The fix also includes:
CombineObservers now happen in the constructor,AtomicReference<Disposable>of the inner observers are now inlined intoCombineObserver,FlowableCombineLatest(no changes required there).