2.x: add missing null check to fused Observable.fromCallable#5517
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jul 25, 2017
Merged
2.x: add missing null check to fused Observable.fromCallable#5517akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5517 +/- ##
============================================
- Coverage 96.24% 96.07% -0.17%
+ Complexity 5811 5801 -10
============================================
Files 631 631
Lines 41285 41285
Branches 5732 5732
============================================
- Hits 39734 39665 -69
- Misses 604 637 +33
- Partials 947 983 +36
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Jul 25, 2017
artem-zinnatullin
approved these changes
Jul 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a missing null check on the fusion path in
ObservableFromCallablewhich meant the consumer considered the source to be empty. (TheFlowableFromCallablewas okay.)Discovered on StackOverflow: https://stackoverflow.com/questions/45304226/null-handling-in-rx-java2-flatmap
Unit test mirrored and updated to verify both
FlowableandObservableversions.