2.x: fix SpscLAQ nepotism, FlowableRefCountTest.testRefCountAsync flaky#5507
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jul 20, 2017
Merged
2.x: fix SpscLAQ nepotism, FlowableRefCountTest.testRefCountAsync flaky#5507akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5507 +/- ##
============================================
- Coverage 96.04% 96.02% -0.03%
+ Complexity 5808 5797 -11
============================================
Files 631 631
Lines 41282 41285 +3
Branches 5732 5732
============================================
- Hits 39651 39645 -6
+ Misses 649 647 -2
- Partials 982 993 +11
Continue to review full report at Codecov.
|
artem-zinnatullin
approved these changes
Jul 20, 2017
This was referenced Jul 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the so-called GC Nepotism (see #3794) in
SpscLinkedArrayQueueby not nulling out the previous buffer's next pointer upon switching buffers in thepeek()/poll()methods.In addition, the FlowableRefCountTest.testRefCountAsync has been reworked to be more forgiving towards unexpected delays due to system load (reported in #5506).