2.x: make withLatestFrom conditional subscriber, test cold consumption#5495
Merged
akarnokd merged 2 commits intoReactiveX:2.xfrom Jul 18, 2017
Merged
2.x: make withLatestFrom conditional subscriber, test cold consumption#5495akarnokd merged 2 commits intoReactiveX:2.xfrom
akarnokd merged 2 commits intoReactiveX:2.xfrom
Conversation
vanniktech
approved these changes
Jul 18, 2017
Codecov Report
@@ Coverage Diff @@
## 2.x #5495 +/- ##
============================================
- Coverage 96.06% 96.03% -0.03%
+ Complexity 5807 5800 -7
============================================
Files 631 631
Lines 41299 41303 +4
Branches 5743 5745 +2
============================================
- Hits 39674 39666 -8
- Misses 639 649 +10
- Partials 986 988 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts #5494 by converting the
withLatestFromoperators into conditional subscribers and adds unit tests that verify a cold source is consumed fully if there is no event(s) from the other source(s).(Also there was a missing space before the bracked and the new unit test name had the
testprefix.)