2.x: fix ReplayProcessor backpressure and NotificationLite emission bug#5493
Merged
akarnokd merged 2 commits intoReactiveX:2.xfrom Jul 18, 2017
Merged
Conversation
artem-zinnatullin
approved these changes
Jul 17, 2017
Codecov Report
@@ Coverage Diff @@
## 2.x #5493 +/- ##
============================================
+ Coverage 96.11% 96.23% +0.12%
- Complexity 5798 5809 +11
============================================
Files 631 631
Lines 41297 41276 -21
Branches 5743 5730 -13
============================================
+ Hits 39692 39723 +31
+ Misses 632 602 -30
+ Partials 973 951 -22
Continue to review full report at Codecov.
|
davidmoten
approved these changes
Jul 18, 2017
vanniktech
approved these changes
Jul 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the replaying algorithms of the
ReplayProcessorto the standard queue-drain and as an added effect, fixes a request-emission race where the internalNotificationLite.completecould be emitted to the consumers.