2.x: small note on Maybe.defaultIfEmpty regarding toSingle#5486
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jul 15, 2017
Merged
2.x: small note on Maybe.defaultIfEmpty regarding toSingle#5486akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5486 +/- ##
============================================
+ Coverage 96.01% 96.08% +0.07%
+ Complexity 5803 5799 -4
============================================
Files 631 631
Lines 41297 41297
Branches 5743 5743
============================================
+ Hits 39650 39682 +32
+ Misses 655 634 -21
+ Partials 992 981 -11
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Jul 13, 2017
This was referenced Jul 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ths PR replaces #5485 regarding the issue of #5480 because our javadoc validation did not allow that type of wording (i.e., mentioning
Singlewhen the method signature is not related to it).