2.x: FlowableTimeoutTimed - replace AtomicReference with mutable field#5466
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jul 5, 2017
Merged
Conversation
akarnokd
approved these changes
Jul 5, 2017
Codecov Report
@@ Coverage Diff @@
## 2.x #5466 +/- ##
============================================
- Coverage 95.94% 95.91% -0.04%
- Complexity 5797 5801 +4
============================================
Files 631 631
Lines 41306 41297 -9
Branches 5745 5743 -2
============================================
- Hits 39633 39610 -23
- Misses 656 669 +13
- Partials 1017 1018 +1
Continue to review full report at Codecov.
|
artem-zinnatullin
approved these changes
Jul 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion in #5461. The timer fields in the Subscriber classes in FlowableTimeoutTimed are
AtomicReferences but this is not required as the fields are accessed synchronously.The
timerfield inTimeoutTimedOtherSubscriberdid require anAtomicReferencebecause of the dispose call here but this call is not required if we just callworker.dispose().No unit test additions.
P.S. 9321 unit tests in RxJava 2.x! An outrageous amount of work, thanks @akarnokd (and other contributors)!