2.x: fix Javadoc mistakes and some style#5460
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jul 3, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5460 +/- ##
===========================================
- Coverage 96.09% 96% -0.09%
Complexity 5797 5797
===========================================
Files 631 631
Lines 41306 41306
Branches 5745 5745
===========================================
- Hits 39694 39657 -37
- Misses 624 643 +19
- Partials 988 1006 +18
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Jul 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes most JavaDoc errors discovered from RxJava 3 preview's javadoc generator (doclint enabled).
(I was unable to make gradle in RxJava 2 to report the same errors regardless of source level and underlying Java 8 runtime locally.)
Changes include:
<dt>in<dl>s<td>to<dt>in<dl>s>in<code>blocks with>(as it is forbidden in doclint of Java 8)<in<code>blocks with<initialSeedmentions fromscanoperators that take aseedSupplierand remove the deferred example as well<code><pre>to<pre><code>.