2x: Fix wording in Async and Publish processors javadoc.#5444
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jun 26, 2017
Merged
2x: Fix wording in Async and Publish processors javadoc.#5444akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
akarnokd
reviewed
Jun 26, 2017
|
|
||
| /** | ||
| * A Subject that multicasts events to Subscribers that are currently subscribed to it. | ||
| * Processor that multicasts all subsequently observed items to its current {@link Subscriber}s. |
Contributor
Author
There was a problem hiding this comment.
In Replay and Behaviour processors it's "Processor" _(ツ)_/¯. Both seam syntactically correct.
Member
There was a problem hiding this comment.
Then the AsyncProcessor could be adjusted as well.
akarnokd
approved these changes
Jun 26, 2017
vanniktech
approved these changes
Jun 26, 2017
49f0259 to
34c4858
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #5444 +/- ##
============================================
+ Coverage 95.96% 96.04% +0.07%
- Complexity 5793 5794 +1
============================================
Files 631 631
Lines 41297 41297
Branches 5744 5744
============================================
+ Hits 39632 39662 +30
+ Misses 663 654 -9
+ Partials 1002 981 -21
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seams that these are some leftovers from the 1.x -> 2.x refactoring.