2.x: concat to report isDisposed consistently with termination#5440
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jun 27, 2017
Merged
2.x: concat to report isDisposed consistently with termination#5440akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5440 +/- ##
============================================
- Coverage 95.96% 95.93% -0.04%
- Complexity 5793 5794 +1
============================================
Files 631 631
Lines 41297 41302 +5
Branches 5744 5744
============================================
- Hits 39632 39622 -10
- Misses 663 667 +4
- Partials 1002 1013 +11
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Jun 26, 2017
artem-zinnatullin
approved these changes
Jun 26, 2017
This was referenced Jun 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure the
Disposableof aconcatoperator reportstruewhen the sequence terminates.Reported in #5439