2.x: fix time bounded replaySubject getValue() inconsistency with getValues() on old items#5434
Merged
akarnokd merged 4 commits intoReactiveX:2.xfrom Jun 21, 2017
Merged
2.x: fix time bounded replaySubject getValue() inconsistency with getValues() on old items#5434akarnokd merged 4 commits intoReactiveX:2.xfrom
akarnokd merged 4 commits intoReactiveX:2.xfrom
Conversation
akarnokd
approved these changes
Jun 21, 2017
Member
akarnokd
left a comment
There was a problem hiding this comment.
LGTM. The build may need several restart as currently it either times out or gets killed by the container for some reason.
vanniktech
approved these changes
Jun 21, 2017
Codecov Report
@@ Coverage Diff @@
## 2.x #5434 +/- ##
============================================
+ Coverage 96.02% 96.07% +0.05%
- Complexity 5787 5801 +14
============================================
Files 631 631
Lines 41291 41297 +6
Branches 5742 5744 +2
============================================
+ Hits 39648 39678 +30
+ Misses 650 634 -16
+ Partials 993 985 -8
Continue to review full report at Codecov.
|
This was referenced Jun 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5433.