2.x: fix buffer(time, maxSize) duplicating buffers on time-size race#5427
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jun 20, 2017
Merged
2.x: fix buffer(time, maxSize) duplicating buffers on time-size race#5427akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5427 +/- ##
============================================
+ Coverage 95.88% 96.05% +0.16%
- Complexity 5789 5792 +3
============================================
Files 631 631
Lines 41297 41291 -6
Branches 5742 5742
============================================
+ Hits 39599 39661 +62
+ Misses 679 633 -46
+ Partials 1019 997 -22
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Jun 19, 2017
This was referenced Jun 20, 2017
This was referenced Jun 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes both the time+maxSize bound
bufferoperators ofFlowableandObservable. The logic didn't properly mutually exclude the timer action and theonNextaction, resulting in probabilistic emission of the same buffer twice.Reported in #5426.