2.x: Add empty source clauses to javadocs of combineLatest operators …#5413
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jun 28, 2017
Merged
2.x: Add empty source clauses to javadocs of combineLatest operators …#5413akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
akarnokd
reviewed
Jun 14, 2017
Member
akarnokd
left a comment
There was a problem hiding this comment.
A couple of "the" are missing.
| * resulting sequence terminates immediately (normally or with all the errors accumulated till that point). | ||
| * If that input source is also synchronous, other sources after it will not be subscribed to. | ||
| * <p> | ||
| * If provided array of source Publishers is empty, resulting sequence completes immediately without emitting |
Member
There was a problem hiding this comment.
"If the provided array of source Publishers is empty, the resulting sequence completes immediately without emitting any items and without any calls to the combiner function."
| * resulting sequence terminates immediately (normally or with all the errors accumulated till that point). | ||
| * If that input source is also synchronous, other sources after it will not be subscribed to. | ||
| * <p> | ||
| * If there are no source Publishers provided, resulting sequence completes immediately without emitting |
Member
There was a problem hiding this comment.
"If there are no source Publishers provided, the resulting sequence completes immediately without emitting any items and without any calls to the combiner function."
Member
|
Are you going to update this PR based on the feedback? |
Contributor
Author
|
Argh, totally forgot about it, sorry. I will update it |
…accepting unspecified number of sources. This commit resolves ReactiveX#5412
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…accepting unspecified number of sources. This commit resolves #5412