DefaultObserver javadoc example fix#5405
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Jun 9, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5405 +/- ##
===========================================
+ Coverage 96.12% 96.2% +0.08%
- Complexity 5783 5785 +2
===========================================
Files 630 630
Lines 41197 41197
Branches 5728 5728
===========================================
+ Hits 39602 39635 +33
+ Misses 624 611 -13
+ Partials 971 951 -20
Continue to review full report at Codecov.
|
Member
|
Thanks for contributing. |
Contributor
Author
|
Sorry, just saw your comment. I'll post a fix for that as well. |
This was referenced Jun 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example in the javadoc of
DefaultObserveris not compiling,DefaultObserveris not aDisposable.This PR updates the javadoc to provide a compiling example.