2.x: make SingleMap not allow map function return null#5378
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom May 30, 2017
Merged
2.x: make SingleMap not allow map function return null#5378akarnokd merged 1 commit intoReactiveX:2.xfrom
akarnokd merged 1 commit intoReactiveX:2.xfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5378 +/- ##
============================================
- Coverage 96.15% 96.13% -0.02%
+ Complexity 5782 5780 -2
============================================
Files 630 630
Lines 41189 41189
Branches 5726 5726
============================================
- Hits 39604 39597 -7
+ Misses 621 619 -2
- Partials 964 973 +9
Continue to review full report at Codecov.
|
akarnokd
approved these changes
May 30, 2017
artem-zinnatullin
approved these changes
May 30, 2017
This was referenced Jun 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found code like below can works
Because Single#just not allow null, so prevent mapper return null.