2.x: add tryOnError to create/XEmitter API#5344
Merged
akarnokd merged 2 commits intoReactiveX:2.xfrom May 16, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5344 +/- ##
===========================================
+ Coverage 96.08% 96.18% +0.1%
- Complexity 5770 5782 +12
===========================================
Files 630 630
Lines 41146 41162 +16
Branches 5714 5721 +7
===========================================
+ Hits 39536 39593 +57
+ Misses 633 613 -20
+ Partials 977 956 -21
Continue to review full report at Codecov.
|
vanniktech
approved these changes
May 16, 2017
| } | ||
| } | ||
|
|
||
| @Override |
JakeWharton
approved these changes
May 16, 2017
|
|
||
| @Test | ||
| public void tryOnError() { | ||
| for (BackpressureStrategy strategy : BackpressureStrategy.values()) { |
This was referenced Jun 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
tryOnErrormethod to the variousEmittertypes used in thecreateoperators that allows the developer to avoid theUndeliverableExceptionin case a cancellation is racing with the emission of an error. The return value indicates a success of the delivery; in case offalse, the developer can decide to log/drop the specific error if that makes sense for him/her.