Correct documented return type of Single#flatMapObservable Function argument#5304
Merged
akarnokd merged 1 commit intoReactiveX:2.xfrom Apr 20, 2017
veyndan:doc-single-flatMapObservable
Merged
Correct documented return type of Single#flatMapObservable Function argument#5304akarnokd merged 1 commit intoReactiveX:2.xfrom veyndan:doc-single-flatMapObservable
akarnokd merged 1 commit intoReactiveX:2.xfrom
veyndan:doc-single-flatMapObservable
Conversation
akarnokd
approved these changes
Apr 20, 2017
Member
|
Thanks! |
Codecov Report
@@ Coverage Diff @@
## 2.x #5304 +/- ##
============================================
- Coverage 96.12% 96.06% -0.07%
+ Complexity 5755 5751 -4
============================================
Files 629 629
Lines 41112 41112
Branches 5705 5705
============================================
- Hits 39520 39493 -27
- Misses 628 648 +20
- Partials 964 971 +7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argument of
Single#flatMapObservableclearly states that it is expecting aFunctionwhich returns anObservableSourcebut the documentation contradicts that.